Repository navigation
Use base-36 change tags in MockCloudDatabase - #580
Open
lukaskubanek wants to merge 2 commits into
Open
lukaskubanek wants to merge 2 commits into
lukaskubanek wants to merge 2 commits into
Conversation
mbrandonw
reviewed
Nov 11, 2026
Comment on lines
+27
to
+28
| // NB: CloudKit uses base-36 change tags (0…9, a…z, 10…zz, 100…). | ||
| mutating func nextRecordChangeTag() -> String { |
Member
There was a problem hiding this comment.
Suggested change
| // NB: CloudKit uses base-36 change tags (0…9, a…z, 10…zz, 100…). | |
| mutating func nextRecordChangeTag() -> String { | |
| mutating func nextRecordChangeTag() -> String { |
lukaskubanek
added a commit
to structuredpath/sqlite-data
that referenced
this pull request
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion in #573. The mock cloud database now hands out change tags as base-36 strings, which is the format actually used by CloudKit.
"0", then"1","2", …,"9","a", …,"z","10", and so on.MockSyncEnginecompares tags with a newisNewerChangeTag(than:)helper, since plain string comparison breaks once tags pass"z". A test covers the ordering.Purely cosmetic for the current behavior, as discussed. The idea is to keep the mock as close to CloudKit as possible for anything that reads
_recordChangeTaglater.